Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @remix-run/eslint-config dependency #7597

Merged
merged 11 commits into from
Dec 13, 2023

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Oct 5, 2023

For #7056, we want to get out of the opinionated game of managing an ESLint config so we want to remove dependencies on @remix-run/eslint-config so it can be deprecated. We simplified the stacks to use a config based on industry recommended configs (remix-run/indie-stack#261, remix-run/blues-stack#215, remix-run/grunge-stack#172).

This PR does the same for all the templates, leveraging the same minimal config as we used in the stacks - mostly based on "recommended" presets.

I also added a helper script for us to use in the future. It's tough to fully validate the templates lint properly in the monorepo with the hoisted deps. I added a new scripts/lint-templates.sh script that can be run outside the repo and will use create-remix to create an app from each of the local templates in a temp/ dir, install deps, and run npm run lint:

# In this case, I'm running from a playgrounds/ folder that is a sibling to the remix repo
../remix/scripts/lint-templates.sh [path-to-remix-repo]

@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2023

⚠️ No Changeset found

Latest commit: 518e46d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11
Copy link
Contributor Author

I think we might need to sync up the eslint deps in the template and the ones in the root repo package.json to get linting working on the template folders during a root eslint run...will look into that next week

@brophdawg11 brophdawg11 changed the base branch from dev to main December 13, 2023 15:12
@brophdawg11 brophdawg11 reopened this Dec 13, 2023
@brophdawg11 brophdawg11 merged commit e8dd645 into main Dec 13, 2023
5 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/template-eslint branch December 13, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate Remix ESLint Config
1 participant