feat!: remove built-ins polyfills on node >= 18 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: aa1ebaa The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
MichaelDeBoey
requested changes
Aug 30, 2023
| "@remix-run/web-file": major | ||
| --- | ||
|
|
||
| Remove polyfills / re-exports for built-ins on node >= 18. This includes but not limited to TextEncoder, TextDecoder, ReadableStreams and Blob. |
There was a problem hiding this comment.
ReadableStream is still marked as Experimental 😢
Suggested change
| Remove polyfills / re-exports for built-ins on node >= 18. This includes but not limited to TextEncoder, TextDecoder, ReadableStreams and Blob. | |
| Remove polyfills / re-exports for built-ins on node >= 18. This includes but not limited to TextEncoder, TextDecoder and Blob. |
There was a problem hiding this comment.
are they still?, ReadableStream is not experimental in Node 18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.