Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove built-ins polyfills on node >= 18 #42

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/poor-trees-hunt.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@remix-run/web-form-data": major
"@remix-run/web-fetch": major
"@remix-run/web-file": major
---

Remove polyfills / re-exports for built-ins on node >= 18. This includes but not limited to TextEncoder, TextDecoder, ReadableStreams and Blob.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReadableStream is still marked as Experimental 😢

Suggested change
Remove polyfills / re-exports for built-ins on node >= 18. This includes but not limited to TextEncoder, TextDecoder, ReadableStreams and Blob.
Remove polyfills / re-exports for built-ins on node >= 18. This includes but not limited to TextEncoder, TextDecoder and Blob.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are they still?, ReadableStream is not experimental in Node 18

77 changes: 0 additions & 77 deletions .github/workflows/blob.yml

This file was deleted.

12 changes: 2 additions & 10 deletions .github/workflows/fetch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
strategy:
matrix:
node-version:
- 16
- 18
project:
- fetch
steps:
Expand All @@ -47,8 +47,6 @@ jobs:
fail-fast: false
matrix:
node-version:
- 14
- 16
- 18
- 20
os:
Expand All @@ -57,12 +55,6 @@ jobs:
- macos-latest
project:
- fetch
exclude:
- os: windows-latest
node-version: 14
# On macOS, run tests with only the LTS environments.
- os: macos-latest
node-version: 14

steps:
- uses: actions/checkout@v3
Expand All @@ -81,7 +73,7 @@ jobs:
# upload coverage only once
- name: Coveralls
uses: coverallsapp/github-action@master
if: matrix.node == '14' && matrix.os == 'ubuntu-latest'
if: matrix.node == '18' && matrix.os == 'ubuntu-latest'
with:
github-token: ${{ secrets.GITHUB_TOKEN }}

Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/file.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
strategy:
matrix:
node-version:
- 16
- 18
project:
- file
steps:
Expand All @@ -45,8 +45,6 @@ jobs:
fail-fast: false
matrix:
node-version:
- 14
- 16
- 18
- 20
os:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/form-data.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
strategy:
matrix:
node-version:
- 16
- 18
project:
- form-data
steps:
Expand All @@ -46,8 +46,6 @@ jobs:
fail-fast: false
matrix:
node-version:
- 14
- 16
- 18
- 20
os:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
cache: 'yarn'
- name: Install
run: yarn install --frozen-lockfile
Expand Down
101 changes: 0 additions & 101 deletions .github/workflows/stream.yml

This file was deleted.

18 changes: 5 additions & 13 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,33 +2,25 @@
"name": "@remix-run/web-std-io",
"private": true,
"workspaces": [
"packages/blob",
"packages/file",
"packages/form-data",
"packages/fetch",
"packages/stream"
"packages/fetch"
],
"scripts": {
"changeset": "changeset",
"release": "changeset publish",
"version-bump": "changeset version",
"postinstall": "manypkg fix",
"prepare": "yarn prepare:blob && yarn prepare:file && yarn prepare:form-data && yarn prepare:fetch",
"prepare:blob": "yarn --cwd packages/blob prepare",
"prepare": "yarn prepare:file && yarn prepare:form-data && yarn prepare:fetch",
"prepare:file": "yarn --cwd packages/file prepare",
"prepare:form-data": "yarn --cwd packages/form-data prepare",
"prepare:fetch": "yarn --cwd packages/fetch prepare",
"test": "yarn test:stream && yarn test:blob && yarn test:file && yarn test:form-data && yarn test:fetch",
"test:blob": "yarn --cwd packages/blob test",
"test": "yarn test:file && yarn test:form-data && yarn test:fetch",
"test:file": "yarn --cwd packages/file test",
"test:form-data": "yarn --cwd packages/form-data test",
"test:fetch": "yarn --cwd packages/fetch test",
"test:stream": "yarn --cwd packages/stream test"
"test:fetch": "yarn --cwd packages/fetch test"
},
"dependencies": {
"@changesets/changelog-github": "0.4.4",
"@changesets/cli": "^2.22.0",
"@manypkg/cli": "0.19.1",
"@manypkg/get-packages": "^1.1.3"
"@changesets/cli": "^2.22.0"
}
}
43 changes: 0 additions & 43 deletions packages/blob/CHANGELOG.md

This file was deleted.

18 changes: 0 additions & 18 deletions packages/blob/License.md

This file was deleted.

Loading