-
Notifications
You must be signed in to change notification settings - Fork 118
Replace okapi_operation with utoipa #4125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e20586d to
a111ae5
Compare
a111ae5 to
3ca3526
Compare
|
Could you post the admin openapi output here? Will run a few tests to see if it generates something sane :) |
|
Here is the generated OpenAPI spec: https://gist.github.com/tillrohrmann/e1a4b749242f3b554ef55c3b994c434f |
3ca3526 to
3b8c6c1
Compare
|
@tillrohrmann this test failure is being tracked already? https://github.com/restatedev/restate/actions/runs/20754507824/job/59594780154?pr=4125#step:12:172 |
slinkydeveloper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the changes i posted here, code generation of the docs works fine and LGTM
3b8c6c1 to
df74195
Compare
df74195 to
094ec11
Compare
Not yet. Will create the corresponding issue. The issue is #4152. |
@nikrooz did you try out the latest version of this PR? I've pushed an update to address the issue with the "400 Bad Request". It should now generate "400". |
You are right. There is restate/crates/types/src/schema/service.rs Lines 64 to 65 in 094ec11
|
You are right @nikrooz. There is restate/crates/types/src/schema/service.rs Lines 64 to 65 in 094ec11
|
The dependency okapi_operation is no longer actively maintained and blocks Restate from upgrading the schemars dependency. Moreover, it only generates OpenAPI 3.0 specs. To solve this problem, this commit replaces the okapi_operation dependency with the more actively maintained utoipa dependency which allows us to generate OpenAPI 3.1. Moreover, it will allow us to eventually drop the restate-utoipa fork once we upstream the added changes. As part of this rework, we added the SQL query endpoint to the OpenAPI documentation and removed the feature gate.
094ec11 to
d13b9f5
Compare




The dependency okapi_operation is no longer actively maintained and blocks Restate
from upgrading the schemars dependency. Moreover, it only generates OpenAPI 3.0 specs.
To solve this problem, this commit replaces the okapi_operation dependency with the
more actively maintained utoipa dependency which allows us to generate OpenAPI 3.1.
Moreover, it will allow us to eventually drop the restate-utoipa fork once we upstream
the added changes.
As part of this rework, we added the SQL query endpoint to the OpenAPI documentation
and removed the feature gate.