BREAKING: use Deno tooling #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes revolt.js so that there is no longer a CJS build. CJS users of revolt.js can still import it using versions of Node.js after nodejs/node#51977 was merged. The dependencies on the isomorphic-ws and ws packages were also removed. This does make the minimum supported version the latest LTS, Node.js 22. In browsers and Deno, nothing should change. The dependencies on Solid.js were also removed, making a breaking change for users who used the reactivity from the Solid.js wrappers. Import paths throughout the project were rewritten to import from the original source files everywhere. Prettier, ESLint, and Typescript were all updated to their latest versions as well. Signed-off-by: Jersey <[email protected]>
Signed-off-by: Jersey <[email protected]>
|
I think it'd be a decent idea to split this up if possible? some of these changes look smaller/easier to merge |
|
yeah, i'm going to work on splitting this up into a few other PRs. i'll keep this one open until i'm done with that |
2 tasks
williamhorning
changed the title
|
since two of the split up prs have been merged, this and #114 (which this should be based on) have quite a lot of merge conflicts but i'll try and resolve those on my end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes a lot about revolt.js, mostly in terms of dependencies and how to build it. Most of the changes here are done to both remove dependencies and support Deno more.
This includes changes from #112, #113, and #114 as well as the following:
In addition to these changes, insertish/oapi#3 removes the
axiosandlodash.defaultsdeepdependencies from oapi andrevolt-apiby proxy.That combined with this PR should make for both Node, Deno, and browser support while publishing to both npm and JSR with just three dependencies:
@vladfrangu/async_event_emitterrevolt-apiulidThis fixes #34
Please make sure to check the following tasks before opening and submitting a PR