Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: remove polyfilles, CJS build, and update dev dependencies #112

Merged
merged 6 commits into from
Mar 23, 2025

Conversation

williamhorning
Copy link
Contributor

@williamhorning williamhorning commented Mar 14, 2025

  • BREAKING: remove isomorphic-ws and ws. node 22+ (current LTS) support WebSocket out of the box so there's no need to keep shipping these polyfills
  • BREAKING: remove CJS builds. node 20+ support requiring synchronous ESM graphs, so there's no reason to ship a CJS build anymore
  • chore: update prettier and eslint to their latest versions
  • chore: fix lint and formatting errors (mostly trailing commas)

this, along with insertish/oapi#3 should reduce what revolt.js depends on without breaking any usecases

this does break support for node <22, but we shouldn't support anything less than the latest LTS

dependency graph


  • I understand and have followed the contribution guide
  • I have tested my changes locally and they are working as intended

@StupidRepo
Copy link

I did see the comment posted in #111 but this PR has an almost identical title to the other one. What's the difference between them? 🤔

@williamhorning
Copy link
Contributor Author

@StupidRepo unlike that, this pr doens't remove any of the solid components, doesn't fix the imports or return types, and doesn't move over to deno tooling. those will all be separate PRs

@StupidRepo
Copy link

@StupidRepo unlike that, this pr doens't remove any of the solid components, doesn't fix the imports or return types, and doesn't move over to deno tooling. those will all be separate PRs

Ah okay 👍🏻

@williamhorning williamhorning mentioned this pull request Mar 14, 2025
2 tasks
@github-project-automation github-project-automation bot moved this from 🆕 Untriaged to 💡 Ready to merge in Pull Request Overview Mar 23, 2025
@insertish insertish added this pull request to the merge queue Mar 23, 2025
Merged via the queue into revoltchat:main with commit 2178677 Mar 23, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from 💡 Ready to merge to ✅ Merged in Pull Request Overview Mar 23, 2025
@williamhorning williamhorning deleted the break-node-prior-to-22 branch March 23, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Merged
Development

Successfully merging this pull request may close these issues.

3 participants