target/riscv: fix ub during instruction decode #1299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aap-sc
requested review from
JanMatCodasip,
MarekVCodasip and
en-sc
and removed request for
MarekVCodasip
A left shift operation caused an implicit integer promotion, triggering the following UBSan error: ``` left shift of 254 by 24 places cannot be represented in type 'int' ``` NOTE: it seems that this code won't work correctly with BE targets, however this is a general problem of the whole implementation anyway. Signed-off-by: Anatoly Parshintsev <[email protected]>
aap-sc
force-pushed
the
aap-sc/garbage_watchpoint_ub
branch
from
0d0f743 to
537d22f
Compare
aap-sc
added a commit
to syntacore/openocd
that referenced
this pull request
Oct 15, 2025
A left shift operation caused an implicit integer promotion, triggering the following UBSan error: ``` left shift of 254 by 24 places cannot be represented in type 'int' ``` NOTE: it seems that this code won't work correctly with BE targets, however this is a general problem of the whole implementation anyway. See: riscv-collab/riscv-openocd#1299 Signed-off-by: Anatoly Parshintsev <[email protected]>
en-sc
approved these changes
Oct 22, 2025
Collaborator
en-sc
left a comment
en-sc
left a comment
There was a problem hiding this comment.
LGTM (reviewed internally).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A left shift operation caused an implicit integer promotion, triggering the following UBSan error:
NOTE: it seems that this code won't work correctly with BE targets, however this is a general problem of the whole implementation anyway.