This repository was archived by the owner on Jul 17, 2026. It is now read-only.
Align LOG_* messages with upstream style - remove trailing punctuation (#1212) - #1321
Open
habeelali wants to merge 1 commit into
Open
Align LOG_* messages with upstream style - remove trailing punctuation (#1212)#1321habeelali wants to merge 1 commit into
habeelali wants to merge 1 commit into
Conversation
riscv-collab#1212) Remove trailing period and exclamation mark from log messages in src/target/riscv/* to match OpenOCD C style guide. Multi-sentence messages are left unchanged as per issue instructions. Made-with: Cursor
Collaborator
|
Hi @habeelali, thanks for your patch. I assume this stale repository will get archived in near term, so you may implement your improvement in the OpenOCD upstream instead: review.openocd.org. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1212. Removes trailing period/exclamation from log messages in src/target/riscv/* per OpenOCD C style guide. Multi-sentence messages were left unchanged.