Conversation
|
@TomHawk123 it looks like the I'll submit locking the |
Used safe var helper to ensure proper integer is being used for GraphQL depth Using Node 24.14.0, as directed to make CI happy
pawiecz
left a comment
There was a problem hiding this comment.
Patch looks good!
I'll merge #112 so we could address the CI warning.
I don't think I can merge until @juanmrad approves the PR after addressing his change request and/or until the CI warning can be addressed. |
|
@TomHawk123 can you merge main to re-trigger CI and make sure all passes. |
This change addresses ESLint warning about type safety of JSON.stringify.
|
This PR still has misaligned Betterer results (even after merging recent changes from I'll run Betterer again on this branch, amend the results so that CI doesn't complain about the results getting improved (sigh) and merge this PR. |
Context & Requests for Reviewers
This PR answers Issue #108
Tests
Ran locally and slammed the server with an overly complex query to confirm crashing of service. Implemented depth limit of 10 and tested:
Expected to Fail:
Expected to Succeed:
(Optional) Rollout Plan
After testing by reviewers, this should be able to rollout immediately.