Updated ament_index_cpp API #82
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Member
|
@ahcorde Do you know if this change is going to be backported to older distros until Humble? |
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Author
|
@saikishor this should work on |
Member
Thank you. |
saikishor
reviewed
Jan 22, 2026
| // Add ros2 control icon for the taskbar | ||
| std::string icon_location = | ||
| std::string icon_location; | ||
| #if AMENT_INDEX_CPP_VERSION_GTE(1, 13, 0) |
Member
There was a problem hiding this comment.
@ahcorde Seems like this macro is not found. I don't see the ament_index_cpp package having version.h header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with ament/ament_index#104
Warning https://build.ros2.org/view/Rdev/job/Rdev__mujoco_ros2_control__ubuntu_noble_amd64/15/