Skip to content

Conversation

saikishor
Copy link
Member

I've added a way to initialize the current parameter from the ROS nodes directly, much easier when using with nodes and controllers

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 70.96774% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.53%. Comparing base (cb06c3e) to head (9d6a237).

Files with missing lines Patch % Lines
.../include/realtime_tools/async_function_handler.hpp 62.50% 3 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
- Coverage   86.62%   85.53%   -1.10%     
==========================================
  Files          17       17              
  Lines        1391     1438      +47     
  Branches      117      133      +16     
==========================================
+ Hits         1205     1230      +25     
- Misses        111      121      +10     
- Partials       75       87      +12     
Flag Coverage Δ
unittests 85.53% <70.96%> (-1.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ealtime_tools/test/test_async_function_handler.cpp 100.00% <100.00%> (ø)
.../include/realtime_tools/async_function_handler.hpp 75.36% <62.50%> (-6.91%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in principle LGTM.

Do you plan to update ros-controls/ros2_control#2477 with this?

@saikishor
Copy link
Member Author

in principle LGTM.

Do you plan to update ros-controls/ros2_control#2477 with this?

Not really
I've just added it for future purposes. Maybe for the controller interface class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants