Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of M_PI in steering_controllers_library and tricycle_controller #1536

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Feb 12, 2025

The PR #1451 also accidentally deleted some _USE_MATH_DEFINES definition defined at the CMake level, that were added in #1036 . To fix this, I reintroduce the _USE_MATH_DEFINES, just at compilation unit level instead of CMake level, as discussed in ros-controls/ros2_control#2001 (comment) .

To send us a pull request, please:

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.27%. Comparing base (ae6efeb) to head (5cdcbf9).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1536   +/-   ##
=======================================
  Coverage   84.27%   84.27%           
=======================================
  Files         123      123           
  Lines       11359    11361    +2     
  Branches      961      962    +1     
=======================================
+ Hits         9573     9575    +2     
  Misses       1470     1470           
  Partials      316      316           
Flag Coverage Δ
unittests 84.27% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ring_controllers_library/src/steering_odometry.cpp 82.53% <ø> (ø)
...ontrollers_library/test/test_steering_odometry.cpp 100.00% <ø> (ø)
tricycle_controller/src/tricycle_controller.cpp 66.80% <ø> (ø)

... and 4 files with indirect coverage changes

@christophfroehlich christophfroehlich merged commit c83cfb3 into ros-controls:master Feb 12, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants