Skip to content

Fix another shutdown race with rqt_jtc#2467

Open
christophfroehlich wants to merge 1 commit into
masterfrom
rqt-shutdown-race
Open

Fix another shutdown race with rqt_jtc#2467
christophfroehlich wants to merge 1 commit into
masterfrom
rqt-shutdown-race

Conversation

@christophfroehlich

Copy link
Copy Markdown
Member

Description

Fixes #2444 #2464 #2465

Is this user-facing behavior change?

no

Did you use Generative AI?

GPT Codex 5.3

@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.83%. Comparing base (c7b97ca) to head (7d6fb71).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ajectory_controller/joint_trajectory_controller.py 55.55% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2467      +/-   ##
==========================================
- Coverage   86.83%   86.83%   -0.01%     
==========================================
  Files         148      148              
  Lines       16273    16282       +9     
  Branches     1368     1370       +2     
==========================================
+ Hits        14131    14138       +7     
  Misses       1635     1635              
- Partials      507      509       +2     
Flag Coverage Δ
unittests 86.83% <55.55%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ajectory_controller/joint_trajectory_controller.py 37.71% <55.55%> (+1.05%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich added backport-humble Triggers PR backport to ROS 2 humble. backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted. labels Jul 10, 2026
@christophfroehlich christophfroehlich moved this to Needs review in Review triage Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-humble Triggers PR backport to ROS 2 humble. backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted.

Projects

Status: Needs review

Development

Successfully merging this pull request may close these issues.

CI build job rolling/testing failed! CI build job lyrical/testing failed! CI build job lyrical/main failed!

1 participant