Propagate clock instead of creating default#458
Closed
redvinaa wants to merge 2 commits intoros:ros2-humblefrom
Closed
Propagate clock instead of creating default#458redvinaa wants to merge 2 commits intoros:ros2-humblefrom
redvinaa wants to merge 2 commits intoros:ros2-humblefrom
Conversation
ct2034
added
bug
Contributor
|
Please make all PRs against the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were having trouble with diagnostics being stale in simulation when the real time factor is low. I noticed that the analyzers are creating new clocks (that use by default system time), instead of propagating down the clock of the main node (that uses the correct time in both simulation and real life).
I couldn't find any issues about this, so I implemented a fix.