-
Notifications
You must be signed in to change notification settings - Fork 53
Migrate std::bind calls to lambda expressions #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two changes to pass linters, then this is probably good to go.
Co-authored-by: Chris Lalancette <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more linter error (not sure why this didn't show up in the earlier run).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2024-01-08T15:02:27.9197222Z 7: --- src/turtle_tf2_listener.cpp
2024-01-08T15:02:27.9197566Z 7: +++ src/turtle_tf2_listener.cpp.uncrustify
2024-01-08T15:02:27.9197935Z 7: @@ -56 +56 @@
2024-01-08T15:02:27.9198266Z 7: - 1s, [this](){return this->on_timer();});
2024-01-08T15:02:27.9198687Z 7: + 1s, [this]() {return this->on_timer();});
Co-authored-by: Chris Lalancette <[email protected]>
I executed |
This PR is a follow up to the changes made in the documentation ros2/ros2_documentation#4041
The migration of std::bind calls made in the docs is reflected here