-
Notifications
You must be signed in to change notification settings - Fork 153
Backport the equals and not equals substitutions #864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: humble
Are you sure you want to change the base?
Conversation
Signed-off-by: suchetanrs <[email protected]>
@christophebedard can we get a review and CI job for this? |
Pulls: #864 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
It's useful to link to the original PR in the PR description when making a backport: #649 (partial backport in this case).
I don't want to devalue effort that @suchetanrs has put in, but I also want to maintain branch cohesion as much as possible so that future backports remain easier. I might suggest we go with #871 instead of this PR, it is a complete cherry-pick backport of the original contribution. It backports the same substitutions but also the Either that or I can follow up with #871 to fill in the remaining features that weren't backported here. |
It's up to you guys |
I agree with @emersonknapp that #871 is a full backport and is more feature complete than this PR. Please feel free to prefer #871 instead of this if the need be. |
Hello,
This PR backports the equals and not equals substitutions to humble along with their tests.
Update:
More information:
This is a backport of the PR #649