Skip to content

Backport the equals and not equals substitutions #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: humble
Choose a base branch
from

Conversation

suchetanrs
Copy link

@suchetanrs suchetanrs commented Apr 27, 2025

Hello,

This PR backports the equals and not equals substitutions to humble along with their tests.

Update:
More information:

This is a backport of the PR #649

@SteveMacenski
Copy link

@christophebedard can we get a review and CI job for this?

@ahcorde
Copy link
Contributor

ahcorde commented May 2, 2025

Pulls: #864
Gist: https://gist.githubusercontent.com/ahcorde/7b0f380bf94595cae9edd62a5f2f0554/raw/3b6e4f5aff2be28bffe9936f28f46ca9352ba344/ros2.repos
BUILD args: --packages-above-and-dependencies launch
TEST args: --packages-above launch
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15887

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

It's useful to link to the original PR in the PR description when making a backport: #649 (partial backport in this case).

@ahcorde
Copy link
Contributor

ahcorde commented May 5, 2025

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@emersonknapp
Copy link
Contributor

I don't want to devalue effort that @suchetanrs has put in, but I also want to maintain branch cohesion as much as possible so that future backports remain easier. I might suggest we go with #871 instead of this PR, it is a complete cherry-pick backport of the original contribution. It backports the same substitutions but also the All and Any ones which were in #649. It leaves in the 1 and 0 boolean values in the test suite, which are possible with the backport in #872

Either that or I can follow up with #871 to fill in the remaining features that weren't backported here.

@christophebedard
Copy link
Member

It's up to you guys

@suchetanrs
Copy link
Author

suchetanrs commented May 6, 2025

I agree with @emersonknapp that #871 is a full backport and is more feature complete than this PR. Please feel free to prefer #871 instead of this if the need be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants