Skip to content

Allow for implicitly convertable loggers as well #2922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: rolling
Choose a base branch
from

Conversation

Timple
Copy link
Contributor

@Timple Timple commented Jul 31, 2025

Description

This way I can inherit from rclpp::Logger and still pass it to the logger macros.

Is this user-facing behavior change?

Backwards compatible

Did you use Generative AI?

No

Additional Information

If accepted I would like to have this backported to active distros as well.

@Timple Timple force-pushed the feature/multiple-logger-implementations branch from 92e99c4 to 99e11a3 Compare July 31, 2025 08:33
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI.

The new check enables more flexible and extensible code, allowing for future enhancements and custom logger types. It also prevents compile errors when a compatible logger type (not strictly rclcpp::Logger) is used.

@fujitatomoya fujitatomoya requested a review from ahcorde August 1, 2025 04:20
@fujitatomoya
Copy link
Collaborator

Pulls: #2922
Gist: https://gist.githubusercontent.com/fujitatomoya/38955bee08885a052238f60933001082/raw/fccdf9cc7a4da7a40ad9a982049234aafe57abf9/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16659

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@Timple
Copy link
Contributor Author

Timple commented Aug 5, 2025

Is CI flaky or is this something I introduced?

@christophebedard
Copy link
Member

@ros-pull-request-builder retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants