Improve the function extract_type_identifier #2923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Barry Xu <[email protected]>
fujitatomoya
approved these changes
Aug 5, 2025
| @@ -73,6 +73,19 @@ const void * get_typesupport_handle_impl( | |||
| } | |||
| } | |||
|
|
|||
| std::string string_trim(std::string_view str_v) | |||
There was a problem hiding this comment.
how about the following? instead of removing the space one by one? i believe it only scans the string twice, not once per whitespace character, and could be more readable and idiomatic.
std::string string_trim(std::string_view str_v) {
auto begin = std::find_if_not(str_v.begin(), str_v.end(), [](unsigned char ch) {
return std::isspace(ch);
});
auto end = std::find_if_not(str_v.rbegin(), str_v.rend(), [](unsigned char ch) {
return std::isspace(ch);
}).base();
if (begin >= end) return {};
return std::string(begin, end);
}There was a problem hiding this comment.
Thanks. This way is more efficient.
Signed-off-by: Barry Xu <[email protected]>
jmachowinski
approved these changes
Aug 12, 2025
|
Pulls: #2923
|
ahcorde
requested changes
Aug 18, 2025
| // Trim leading and trailing whitespace from the string. | ||
| std::string string_trim(std::string_view str_v) | ||
| { | ||
| auto begin = std::find_if_not(str_v.begin(), str_v.end(), [](unsigned char ch) { |
Signed-off-by: Barry Xu <[email protected]>
|
Run CI again
|
ahcorde
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve rclcpp::extract_type_identifier()
There are 2 issues reported in rosbag2 on extract_type_identifier().
ros2/rosbag2#2111
ros2/rosbag2#2113
Background:
The implementation of rosbag2::extract_type_identifier() has been moved to rclcpp::extract_type_identifier(). The rosbag2::extract_type_identifier() function will be removed in ros2/rosbag2#2017. Therefore, the fix should be made on the rclcpp side.
Fixes ros2/rosbag2#2111 and ros2/rosbag2#2113
Is this user-facing behavior change?
No
Did you use Generative AI?
No