Update rosbag2_py stubs #1593
Merged
Update rosbag2_py stubs #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Sokolkov <[email protected]>
r7vme
requested review from
MichaelOrlov and
james-rms
and removed request for
a team
fujitatomoya
approved these changes
Mar 20, 2024
MichaelOrlov
approved these changes
Mar 20, 2024
|
Since changes only in auto-generated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to a recent change that added stub files #1569
PR above was not rebased to the latest rolling, which had pybind11 changes, before merging. This caused a "race condition" - CI was green, but after rebasing it would fail. Seems, when making changes to rosbag2_py (pybind11), we need to make sure to rebase to latest rolling before merge.