Skip to content

Keep discovery running for mixed topic selectors - #2450

Open
Old-Ding wants to merge 1 commit into
ros2:rollingfrom
Old-Ding:codex/keep-discovery-for-mixed-selectors
Open

Keep discovery running for mixed topic selectors#2450
Old-Ding wants to merge 1 commit into
ros2:rollingfrom
Old-Ding:codex/keep-discovery-for-mixed-selectors

Conversation

@Old-Ding

Copy link
Copy Markdown
Contributor

Summary

  • preserve the early-stop optimization only when explicit topics are the sole inclusive selector
  • keep discovery active when topics are combined with regex, type, service, action, all, or static-topic selectors
  • add a regression test where a regex topic is subscribed before a later explicit topic appears

Fixes #2417

Testing

  • git diff --check
  • not run locally: test_record_regex requires a ROS 2/colcon environment that is not available on this machine

Only stop discovery after explicit topics are subscribed when no other inclusive selector can discover additional topics later.

Add a regression test that introduces an explicitly requested topic after a regex-matched topic has already been subscribed.

Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recording with both --regex and --topics stops discovery early

1 participant