Fix excluded action filtering in player - #2451
Open
Old-Ding wants to merge 1 commit into
Open
Conversation
The action-interface branch checked whether the topic exclusion list was empty before consulting the action exclusion list. Use the owning action list and extend the existing playback test to cover include/exclude precedence and client creation. Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
baseline=allowedand confirmingfixed=excludedwhen only the action exclusion list is populatedgit diff --checkThe repository-native C++ test was not run locally because this Windows environment does not have the ROS 2 build dependencies or colcon. Repository CI covers the full integration test.