Skip to content

Fix excluded action filtering in player - #2451

Open
Old-Ding wants to merge 1 commit into
ros2:rollingfrom
Old-Ding:codex/fix-player-exclude-actions
Open

Fix excluded action filtering in player#2451
Old-Ding wants to merge 1 commit into
ros2:rollingfrom
Old-Ding:codex/fix-player-exclude-actions

Conversation

@Old-Ding

@Old-Ding Old-Ding commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • check the action exclusion list before filtering action-interface topics instead of checking the unrelated topic exclusion list
  • preserve include filtering while making action exclusions take precedence during publisher/client preparation
  • extend the existing action playback test to verify that only the non-excluded action client is created

Testing

  • compiled and ran a focused C++ probe reproducing baseline=allowed and confirming fixed=excluded when only the action exclusion list is populated
  • verified the generic, service, and action branches each use their owning exclusion list
  • verified the regression scenario includes both actions, excludes one, and expects exactly one action client
  • git diff --check

The repository-native C++ test was not run locally because this Windows environment does not have the ROS 2 build dependencies or colcon. Repository CI covers the full integration test.

The action-interface branch checked whether the topic exclusion list was empty before consulting the action exclusion list. Use the owning action list and extend the existing playback test to cover include/exclude precedence and client creation.

Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant