Skip to content

Fix standalone SQLite exclusion filters - #2452

Open
Old-Ding wants to merge 1 commit into
ros2:rollingfrom
Old-Ding:codex/fix-sqlite-exclude-only-filters
Open

Fix standalone SQLite exclusion filters#2452
Old-Ding wants to merge 1 commit into
ros2:rollingfrom
Old-Ding:codex/fix-sqlite-exclude-only-filters

Conversation

@Old-Ding

@Old-Ding Old-Ding commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • avoid leading commas when SQLite exclusion filters contain service events but no ordinary topics
  • apply the same delimiter rule when action interfaces are the first populated exclusion list
  • add real SQLite storage coverage for service-only and action-only blacklists

Testing

  • reproduced the generated NOT IN (,'...') query failing with near ,: syntax error in native SQLite
  • verified corrected service-only and action-only NOT IN ('...') queries execute successfully and remove only the requested item
  • verified both regression cases read nine of the ten fixture topics and omit the selected service/action interface
  • UTF-8 without BOM and CRLF checks
  • 100-column check
  • git diff --check

The repository-native C++ test was not run locally because this Windows environment does not have the ROS 2 build dependencies or colcon. Repository CI covers the SQLite storage test.

Service and action exclusions always prefixed their SQL list fragments with a comma, producing invalid NOT IN clauses when no topic exclusion preceded them. Add delimiters only between populated fragments and cover both standalone filter cases.

Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant