Customizing Reminder Message to Partners

[cielf]

Summary

Provide the ability to customize the reminder message for partners, similar to how we currently allow customization of the distribution email content

Why?

Bank request -- The banks may want to include more info in their reminder message

Details

For clarity, the request is to be able to customize the message that goes out to partners to remind them to put their requests in.

Please follow the pattern we have established with the distribution message. Places that you'll want to look at include
-- the organization edit and show pages (where we let them configure the distribution email)
-- the organization model
-- the distribution mailer
-- the distribution mailer view

Criteria for completion

• implementation of customized reminder messages
• tests supporting customized reminder messages

Bonus round

• Also allow customization of the message reminding partners to pick up the distributions

[nathangthomas]

Good morning! I would like to take this ticket.

[dorner]

You have taken it!

[nathangthomas]

Question regarding the Bonus: Also allow customization of the message reminding partners to pick up the distributions

I am having trouble finding a specific reminder message that goes out to partners who need to pick up. Is there one that I am missing or is this suggesting that if distribution.delivery_method is pick_up we should add another line to distribution_mailer/reminder_email reminding partners of this? Thanks!

[cielf]

You know -- I can't find it either. Please ignore the bonus -- if I find it, I'll create a new issue.

[github-actions]

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

[github-actions]

Automatically unassigned after 7 days of inactivity.

[Sukhpreet-s]

Is this issue still open? Checking on it since it has the stale label and an open PR. If so, I'm happy to work on it.

Also, the open PR seems like a duplicate one from the closed one which was using the wrong approach as mentioned in the other PR comment, so I guess that can be closed 🤔

[cielf]

I was just noting that I need to check into this -- I'm pretty sure the functionality doesn't exist in production yet. Do you want to just start fresh?

[cielf]

@Sukhpreet-s If you want to start fresh, yes , we will close that PR.

[Sukhpreet-s]

Now that you asked me 😅 -- I took a thorough look at the PR and I think the existing code can be used. I'll try to use that PR for now. Thanks!

[nathangthomas]

Hi all, I am the one who originally worked on this story... my apologies for letting it go stale. Strange circumstance, but I was getting jerked around a bit at work and had to put my attention elsewhere. I'm back now with some time if there is something I can do to assist. Best, Nathan Thomas

…

On Thu, Mar 6, 2025 at 12:38 PM Sukh ***@***.***> wrote: Now that you asked me 😅 -- I took a thorough look at the PR and I think the existing code can be used. I'll try to use that PR for now. Thanks! — Reply to this email directly, view it on GitHub <#4176 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALKEMUZHR2MPOV2NDM6QWJD2TCP2JAVCNFSM6AAAAABYPMTYSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBUG43TKMRUGA> . You are receiving this because you were assigned.Message ID: ***@***.***> [image: Sukhpreet-s]*Sukhpreet-s* left a comment (rubyforgood/human-essentials#4176) <#4176 (comment)> Now that you asked me 😅 -- I took a thorough look at the PR and I think the existing code can be used. I'll try to use that PR for now. Thanks! — Reply to this email directly, view it on GitHub <#4176 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALKEMUZHR2MPOV2NDM6QWJD2TCP2JAVCNFSM6AAAAABYPMTYSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBUG43TKMRUGA> . You are receiving this because you were assigned.Message ID: ***@***.***>

[Sukhpreet-s]

@cielf I realized that the old open PR (authored by @nathangthomas) is not merging in rubyforgood/human-essentials repo instead it's merging in the fork itself. And because the PR descriptions mentions this issue, hence the PR is getting tracked here even though it's not merging to this repo.

So I ended up creating a fresh PR.

@nathangthomas Can you please close your PR? Also I wonder if you accidentally created that PR with base branch as your own fork? 🤔