4176 customizing reminder message to partners

[nathangthomas]

Resolves #4176

Description

This PR allows a custom message to be added to the distribution reminder message similar to how we currently make customizations on the distribution email content.

Type of change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

• Tested manually
• Wrote two tests in the distribution_mailer_spec that account for a distribution that includes a custom_reminder

Provide instructions so we can reproduce.
You can test the email manually by:

• run the app locally bin/start
• go to http://localhost:3000/diaper_bank/distributions/1/edit
• add a custom message and ensure that the distribution date and time is for a date in the future.
• open rails c
• run DistributionMailer.reminder_email(Distribution.first.id).deliver_now A mailer preview should open in your browser.

Screenshots

[cielf]

Hey @nathangthomas. Thank you for this!
This is a very broad-stroke review -- I'm not looking at the code at all at this time.

I'm afraid we've got different interpretations of what " similar to how we currently make customizations on the distribution email content" means.

What we are looking for is the addition of a Reminder Email Content that would be the pattern for all reminder emails going out from the organization, i.e. customized at the organization level , not the customized-by-distribution approach in your PR. Doing it at the distribution level would result in duplication of effort for the banks.

Care to give it another go, with that clarification?

Thanks again.

[nathangthomas]

Yes, I'll take another look with the clarification in mind. Thanks!

[dorner]

@nathangthomas are you still interested in finishing this?

[dorner]

Going to close this - no activity and based on the comments it was not taking the right approach.