forked from rubyforgood/human-essentials
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4176 customizing reminder message to partners #1
Open
nathangthomas
wants to merge
13
commits into
main
Choose a base branch
from
4176-customizing-reminder-message-to-partners
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
4176 customizing reminder message to partners #1
nathangthomas
wants to merge
13
commits into
main
from
4176-customizing-reminder-message-to-partners
+79
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @nathangthomas -- I see you have two prs related to this, and the second one is WIP. Are you looking to have this one merged, or the second one? Thanks. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rubyforgood#4176
Description
This PR allows a custom message to be added to the distribution reminder message similar to how we currently make customizations on the distribution email content.
Type of change
How Has This Been Tested?
distribution_mailer_spec
that account for a distribution that includes acustom_reminder
Provide instructions so we can reproduce.
You can test the email manually by:
bin/start
http://localhost:3000/diaper_bank/distributions/1/edit
rails c
DistributionMailer.reminder_email(Distribution.first.id).deliver_now
A mailer preview should open in your browser.Screenshots