Skip to content

Add dropdown box to allow selecting more results per page #1762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add dropdown box to allow selecting more results per page #1762

wants to merge 1 commit into from

Conversation

daubaris
Copy link

@daubaris daubaris commented Jun 9, 2019

@daubaris daubaris changed the title #1625 Add dropdown box to allow selecting more results per page Add dropdown box to allow selecting more results per page Jun 9, 2019
@sgrif
Copy link
Contributor

sgrif commented Jun 14, 2019

Rather than adding a dropdown for this, could we just up the default sent by the frontend?

@daubaris
Copy link
Author

You mean to just increase the per_page value to 100 to be the default value instead of 10?

per_page: 10,

@sgrif
Copy link
Contributor

sgrif commented Jun 14, 2019

I'd go with either 20 or 50 instead of 100, but yes

@daubaris
Copy link
Author

Wouldn't be better to leave the dropdown just to provide flexibility for the user or will this cause any performance issues? Just curious.

@sgrif
Copy link
Contributor

sgrif commented Jun 14, 2019 via email

@kzys
Copy link
Contributor

kzys commented Jul 17, 2019

FYI, https://metacpan.org/search?size=20&q=foo is having a way to change the page size. https://rubygems.org/search?utf8=✓&query=foo, https://www.npmjs.com/search?q=foo and https://pypi.org/search/?q=foo don't provide the one.

Personally I'd like to increase the default page count to keep it simple.

@locks
Copy link
Contributor

locks commented Aug 5, 2019

Increasing the default page seems like a nice small improvement!

@sgrif
Copy link
Contributor

sgrif commented Sep 4, 2019

@daubaris Are you interested in amending this to increase the default?

@bors
Copy link
Contributor

bors commented Sep 6, 2019

☔ The latest upstream changes (presumably #1817) made this pull request unmergeable. Please resolve the merge conflicts.

@carols10cents
Copy link
Member

I'm sorry we've let this PR sit for so long! I'm going to close it since it's gotten out of date and since there's #1883 that implemented the discussed modifications. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants