-
Notifications
You must be signed in to change notification settings - Fork 640
Add dropdown box to allow selecting more results per page #1762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rather than adding a dropdown for this, could we just up the default sent by the frontend? |
You mean to just increase the crates.io/app/controllers/crates.js Line 11 in 922a7c9
|
I'd go with either 20 or 50 instead of 100, but yes |
Wouldn't be better to leave the dropdown just to provide flexibility for the user or will this cause any performance issues? Just curious. |
I'm not sure that a dropdown to configure this really adds that much
value, but I'm open to being convinced otherwise. Does anyone ever use
these to lower the number of records displayed?
…On Fri, Jun 14, 2019 at 1:28 PM daubaris ***@***.***> wrote:
Wouldn't be better to leave the dropdown just to provide flexibility for the user or will this cause any performance issues? Just curious.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
--
Thanks,
Sean Griffin
|
FYI, https://metacpan.org/search?size=20&q=foo is having a way to change the page size. https://rubygems.org/search?utf8=✓&query=foo, https://www.npmjs.com/search?q=foo and https://pypi.org/search/?q=foo don't provide the one. Personally I'd like to increase the default page count to keep it simple. |
Increasing the default page seems like a nice small improvement! |
@daubaris Are you interested in amending this to increase the default? |
☔ The latest upstream changes (presumably #1817) made this pull request unmergeable. Please resolve the merge conflicts. |
I'm sorry we've let this PR sit for so long! I'm going to close it since it's gotten out of date and since there's #1883 that implemented the discussed modifications. Thank you! |
#1625