Skip to content

Increase default results per page for crates page #1883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2019

Conversation

nkanderson
Copy link
Contributor

No description provided.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @carols10cents (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@nkanderson
Copy link
Contributor Author

Related to #1625 and #1762, I was looking for something straightforward to get started with. It looked like that PR was maybe stale, but I can find another issue if there's a desire to wait longer for the PR author to respond.

@carols10cents
Copy link
Member

Thank you so much! This looks great!

@bors r+

@bors
Copy link
Contributor

bors commented Nov 2, 2019

📌 Commit 595d040 has been approved by carols10cents

@bors
Copy link
Contributor

bors commented Nov 2, 2019

⌛ Testing commit 595d040 with merge b8185a0...

bors added a commit that referenced this pull request Nov 2, 2019
…0cents

Increase default results per page for crates page
@bors
Copy link
Contributor

bors commented Nov 2, 2019

☀️ Test successful - checks-travis
Approved by: carols10cents
Pushing b8185a0 to master...

@bors bors merged commit 595d040 into rust-lang:master Nov 2, 2019
@nkanderson nkanderson deleted the increase_results_per_page branch November 3, 2019 19:59
@nkanderson
Copy link
Contributor Author

😄 excited about my first contribution to crates.io!

Does this supersede #1625 such that it should be closed?

@carols10cents
Copy link
Member

Thank you so much for your contribution!! 🎉 Let me know if you're interested in contributing more -- I'm happy to help figure out good issues to work on or answer any questions!

I think this does mean we can close #1625, thank you for reminding me!

@nkanderson
Copy link
Contributor Author

Definitely! Yeah, I'm interested in contributing more, and was hoping to try something within the Rust part of the codebase. If there are issues you think would be good to check out, I'm up for taking a look and finding one to take on!

@carols10cents
Copy link
Member

carols10cents commented Nov 4, 2019

I just added some detailed instructions to this issue, what do you think? (there's someone who says they're working on it but that was quite some time ago, so I think it's up for grabs again) Let me know if it's not what you're interested in or if you have any questions!

@nkanderson
Copy link
Contributor Author

nkanderson commented Nov 5, 2019

Sure, that one looks great! And I appreciate the detailed instructions :)

I do have a couple questions as I've been exploring the current functionality and getting things running locally:

  • Do you think sending through Mailgun is the best way to test the email content? I took a look in the /tmp/ directory after triggering an email address verification email, and it looked like a json representation that didn't contain the text of the email from what I could tell. (I was able to get Mailgun set up, so this one is more or less moot)
  • Do you have any recommendations for setting up multiple users to test with? It seems like the auth flow through github makes it a little tricky if I want to log in as different users.

@carols10cents
Copy link
Member

Whoops, just saw this! Glad you got mailgun figured out.

Do you have any recommendations for setting up multiple users to test with? It seems like the auth flow through github makes it a little tricky if I want to log in as different users.

Yes, this is a bit unfortunate. Under github's terms of service, you're allowed to have one human account and one "machine account" (an account you create for performing automated tasks). I usually test multi-user things using my "machine account". Does that work for you?

@nkanderson
Copy link
Contributor Author

Oh cool, that should work great, nikbot5000 will soon be a prolific contributor to my local crates.io 😄

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants