-
Notifications
You must be signed in to change notification settings - Fork 640
Increase default results per page for crates page #1883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @carols10cents (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thank you so much! This looks great! @bors r+ |
📌 Commit 595d040 has been approved by |
…0cents Increase default results per page for crates page
☀️ Test successful - checks-travis |
😄 excited about my first contribution to crates.io! Does this supersede #1625 such that it should be closed? |
Thank you so much for your contribution!! 🎉 Let me know if you're interested in contributing more -- I'm happy to help figure out good issues to work on or answer any questions! I think this does mean we can close #1625, thank you for reminding me! |
Definitely! Yeah, I'm interested in contributing more, and was hoping to try something within the Rust part of the codebase. If there are issues you think would be good to check out, I'm up for taking a look and finding one to take on! |
I just added some detailed instructions to this issue, what do you think? (there's someone who says they're working on it but that was quite some time ago, so I think it's up for grabs again) Let me know if it's not what you're interested in or if you have any questions! |
Sure, that one looks great! And I appreciate the detailed instructions :) I do have a couple questions as I've been exploring the current functionality and getting things running locally:
|
Whoops, just saw this! Glad you got mailgun figured out.
Yes, this is a bit unfortunate. Under github's terms of service, you're allowed to have one human account and one "machine account" (an account you create for performing automated tasks). I usually test multi-user things using my "machine account". Does that work for you? |
Oh cool, that should work great, nikbot5000 will soon be a prolific contributor to my local crates.io 😄 Thanks! |
No description provided.