1360 crate ownership invitation token #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
carols10cents
requested changes
Dec 16, 2019
Adds a token to the crate_owner_invitations table to be used in token-based acceptance of invitation via email.
nkanderson
force-pushed
the
1360_invitation_token
branch
from
2191c0e to
83a1db2
Compare
Adds an API endpoint, handler, and web route for token-based acceptance. Also updates crate ownership invitation email to contain a URL with a token for accepting an invitation.
nkanderson
force-pushed
the
1360_invitation_token
branch
from
83a1db2 to
c14a03e
Compare
|
Whew, thanks for your patience @carols10cents! I've been a bit busy with the holidays and things the last couple of weeks. I think you've answered the questions I had, so I made edits as needed and rebased onto master. Looks like CI is passing, so I'm going to mark this as ready for review. |
|
Thank you for your patience! I saw one tiny spot where a URL had 2 slashes and went ahead and fixed that since it was the only thing I saw. This looks great to me! Thank you!! @bors r+ |
|
📌 Commit b12465e has been approved by |
bors
added a commit
that referenced
this pull request
Jan 15, 2020
1360 crate ownership invitation token Completes #1360
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes #1360