Skip to content

Conversation

FranciscoTGouveia
Copy link
Contributor

This PR (based on this comment) introduces a new environment variable, RUSTUP_CONCURRENT_DOWNLOADS.

This allows users to configure how many components are downloaded concurrently -- or, in the case of rustup check, how many toolchains are checked concurrently.

@FranciscoTGouveia FranciscoTGouveia force-pushed the control-concurrent-downloads branch from e437bb8 to d5c884e Compare August 18, 2025 10:18
@FranciscoTGouveia FranciscoTGouveia marked this pull request as ready for review August 18, 2025 10:25
Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this ends up modifying much of the code introduced in the first commit in the second commit, suggest squashing these commits -- they're not really independent.

@FranciscoTGouveia FranciscoTGouveia force-pushed the control-concurrent-downloads branch from 153405c to bd87c3a Compare August 20, 2025 18:05
@FranciscoTGouveia
Copy link
Contributor Author

During a conversation about this PR, it was noted that enabling concurrent downloads by default may introduce a slight performance regression for some users.

With that said, would it be preferable to revert the default behavior of max-concurrency (defined in #4436) and leave it up to the user to opt in to concurrency, or should we keep it and address this, if necessary, in a separate issue or PR?

@djc djc added this pull request to the merge queue Aug 21, 2025
@djc
Copy link
Contributor

djc commented Aug 21, 2025

During a conversation about this PR, it was noted that enabling concurrent downloads by default may introduce a slight performance regression for some users.

With that said, would it be preferable to revert the default behavior of max-concurrency (defined in #4436) and leave it up to the user to opt in to concurrency, or should we keep it and address this, if necessary, in a separate issue or PR?

Let's do that in a separate PR.

Merged via the queue into rust-lang:master with commit cb6718f Aug 21, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants