Minor fixes to the github action #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roypat
requested review from
andreeaflorescu,
lauralt,
stefano-garzarella,
stsquad,
ShadowCurse and
RuoqingHe
as code owners
Signed-off-by: Patrick Roy <[email protected]>
Since the "docker container builds" sanity check is required for merging (so that we can use auto-merge), it needs to always trigger, so drop the filtering based on which files were modified. There's the slight downside that it means we'll need to wait 3+ hours even on PRs that dont actually touch the container, but those are very rare from experience. If it ever becomes a nuisance, we can modify the action to instead do the paths check inside the actual command step, and return early. Leave the check in the `push` target, so that we do not unnecessarily build docker containers after merging though. Signed-off-by: Patrick Roy <[email protected]>
It's better to build too many docker containers than too few, so let's go with not triggering the build if we know that only files irrelevant to the container are modified (instead of trying to explicitly list all files that are relevant). This way, if the list is stale, we build "too many" containers, whereas with the current solution, we build "too few" containers (see for example rust-vmm#132). Signed-off-by: Patrick Roy <[email protected]>
roypat
force-pushed
the
github-action-qol
branch
from
cff90e4 to
387f9a0
Compare
4 tasks
stefano-garzarella
approved these changes
Jul 10, 2025
ShadowCurse
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrick Roy [email protected]### Summary of the PR
Please summarize here why the changes in this PR are needed.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.