Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sanity): hide global user menu inside Core UI Rendering Context #8591

Draft
wants to merge 1 commit into
base: feat/sapp-2363/studio-rendering-content-capability-gate
Choose a base branch
from

Conversation

juice49
Copy link
Contributor

@juice49 juice49 commented Feb 11, 2025

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 11:19pm
performance-studio ❌ Failed (Inspect) 💬 Add feedback Feb 12, 2025 11:19pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 11:19pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2025 11:19pm
test-next-studio ⬜️ Ignored (Inspect) Feb 12, 2025 11:19pm

Copy link
Contributor Author

juice49 commented Feb 11, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@juice49 juice49 force-pushed the feat/sapp-2363/studio-rendering-context branch from 460ed9a to 2e92148 Compare February 11, 2025 14:57
Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Feb 11, 2025

⚡️ Editor Performance Report

Updated Wed, 12 Feb 2025 23:21:50 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 26.3 efps (38ms) 24.4 efps (41ms) +3ms (+7.9%)
article (body) 63.7 efps (16ms) 84.0 efps (12ms) -4ms (-/-%)
article (string inside object) 27.0 efps (37ms) 26.0 efps (39ms) +2ms (+4.1%)
article (string inside array) 24.4 efps (41ms) 23.3 efps (43ms) +2ms (+4.9%)
recipe (name) 48.8 efps (21ms) 50.0 efps (20ms) -1ms (-2.4%)
recipe (description) 58.8 efps (17ms) 58.8 efps (17ms) +0ms (-/-%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 20.0 efps (50ms) 19.2 efps (52ms) +2ms (+4.0%)
synthetic (string inside object) 19.6 efps (51ms) 20.0 efps (50ms) -1ms (-2.0%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 38ms 41ms 61ms 394ms 685ms 10.3s
article (body) 16ms 17ms 34ms 90ms 206ms 5.6s
article (string inside object) 37ms 38ms 41ms 76ms 217ms 6.8s
article (string inside array) 41ms 43ms 45ms 108ms 214ms 6.8s
recipe (name) 21ms 22ms 26ms 43ms 0ms 7.1s
recipe (description) 17ms 18ms 19ms 33ms 0ms 4.4s
recipe (instructions) 5ms 6ms 7ms 9ms 0ms 3.0s
synthetic (title) 50ms 53ms 65ms 227ms 932ms 13.2s
synthetic (string inside object) 51ms 54ms 58ms 231ms 524ms 7.9s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 41ms 47ms 77ms 454ms 998ms 11.2s
article (body) 12ms 14ms 16ms 93ms 77ms 5.5s
article (string inside object) 39ms 41ms 45ms 141ms 152ms 7.2s
article (string inside array) 43ms 46ms 51ms 284ms 560ms 7.8s
recipe (name) 20ms 22ms 23ms 40ms 0ms 7.2s
recipe (description) 17ms 17ms 19ms 29ms 0ms 4.4s
recipe (instructions) 5ms 6ms 7ms 11ms 0ms 3.0s
synthetic (title) 52ms 56ms 59ms 231ms 902ms 12.7s
synthetic (string inside object) 50ms 54ms 60ms 448ms 1130ms 8.4s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Component Testing Report Updated Feb 12, 2025 11:26 PM (UTC)

❌ Failed Tests (3) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 2m 35s 3 0 3
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 53s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 15s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 35s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 4s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 44s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@juice49 juice49 changed the base branch from feat/sapp-2363/studio-rendering-context to graphite-base/8591 February 12, 2025 23:01
@juice49 juice49 force-pushed the feat/sapp-2035/core-ui-hide-user-menu branch from d0546ef to 3363ff9 Compare February 12, 2025 23:01
@juice49 juice49 changed the base branch from graphite-base/8591 to feat/sapp-2363/studio-rendering-content-capability-gate February 12, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant