Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sanity): add CapabilityGate component #8621

Draft
wants to merge 1 commit into
base: feat/sapp-2363/studio-rendering-context
Choose a base branch
from

Conversation

juice49
Copy link
Contributor

@juice49 juice49 commented Feb 12, 2025

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 11:10pm
performance-studio ❌ Failed (Inspect) 💬 Add feedback Feb 12, 2025 11:10pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 11:10pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2025 11:10pm
test-next-studio ⬜️ Ignored (Inspect) Feb 12, 2025 11:10pm

Copy link
Contributor Author

juice49 commented Feb 12, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

No changes to documentation

Copy link
Contributor

⚡️ Editor Performance Report

Updated Wed, 12 Feb 2025 23:18:26 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 24.4 efps (41ms) 26.3 efps (38ms) -3ms (-7.3%)
article (body) 67.6 efps (15ms) 67.6 efps (15ms) -0ms (-/-%)
article (string inside object) 27.0 efps (37ms) 27.8 efps (36ms) -1ms (-2.7%)
article (string inside array) 24.4 efps (41ms) 23.8 efps (42ms) +1ms (+2.4%)
recipe (name) 45.5 efps (22ms) 52.6 efps (19ms) -3ms (-13.6%)
recipe (description) 52.6 efps (19ms) 58.8 efps (17ms) -2ms (-10.5%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 20.4 efps (49ms) 20.0 efps (50ms) +1ms (+2.0%)
synthetic (string inside object) 20.4 efps (49ms) 20.4 efps (49ms) +0ms (-/-%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 41ms 62ms 77ms 572ms 878ms 11.6s
article (body) 15ms 17ms 23ms 115ms 240ms 5.4s
article (string inside object) 37ms 40ms 44ms 104ms 322ms 7.1s
article (string inside array) 41ms 43ms 49ms 162ms 147ms 6.8s
recipe (name) 22ms 24ms 35ms 67ms 1ms 7.4s
recipe (description) 19ms 21ms 25ms 35ms 0ms 4.9s
recipe (instructions) 5ms 6ms 9ms 10ms 0ms 3.0s
synthetic (title) 49ms 51ms 66ms 330ms 728ms 12.8s
synthetic (string inside object) 49ms 52ms 55ms 267ms 409ms 7.8s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 38ms 41ms 54ms 451ms 876ms 10.5s
article (body) 15ms 17ms 19ms 84ms 180ms 5.2s
article (string inside object) 36ms 38ms 42ms 302ms 329ms 6.7s
article (string inside array) 42ms 43ms 46ms 88ms 168ms 6.8s
recipe (name) 19ms 20ms 26ms 42ms 0ms 7.3s
recipe (description) 17ms 18ms 20ms 27ms 0ms 4.4s
recipe (instructions) 5ms 6ms 8ms 14ms 0ms 3.0s
synthetic (title) 50ms 53ms 59ms 221ms 536ms 12.1s
synthetic (string inside object) 49ms 53ms 60ms 235ms 527ms 7.5s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Copy link
Contributor

Component Testing Report Updated Feb 12, 2025 11:22 PM (UTC)

❌ Failed Tests (2) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 9s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 58s 4 0 2
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 53s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 15s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 8s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 36s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 4s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 44s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant