Fix/missing character info maintenance#666
Conversation
…formation It could happen that refresh_tokens were present but the character was not. This may cause errors This addresses #665
There was a problem hiding this comment.
Pull Request Overview
This PR addresses configuration inconsistencies by updating the MariaDB action's host port to match the documented default.
- Updated host port from 3308 to 3306 in the GitHub workflow configuration
- Retained commented configuration options for container port and character set for potential future use
Files not reviewed (8)
- database/migrations/2025_01_02_185356_fix_killmail_items_table.php: Language not supported
- phpunit.xml: Language not supported
- src/Jobs/Hydrate/Maintenance/GetMissingCharacterInfos.php: Language not supported
- src/Jobs/Hydrate/Maintenance/GetMissingTypesFromLocations.php: Language not supported
- src/Jobs/Seatplus/MaintenanceJob.php: Language not supported
- src/Jobs/Seatplus/UpdateCorporation.php: Language not supported
- src/Models/Contacts/ContactLabel.php: Language not supported
- src/Services/Esi/UpdateRefreshTokenService.php: Language not supported
PR Summary
|
|
Code Climate has analyzed commit 23a3a4f and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 96.1% (50% is the threshold). This pull request will bring the total coverage in the repository to 89.9% (0.0% change). View more on Code Climate. |
Extend maintenance job with GetMissingCharacterInfos to handle missing character information
It could happen that refresh_tokens were present but the character was not. This may cause errors
This addresses partially #665