Skip to content

Fix/missing character info maintenance#666

Merged
herpaderpaldent merged 5 commits into3.xfrom
fix/missing-character-info-maintenance
Apr 20, 2025
Merged

Fix/missing character info maintenance#666
herpaderpaldent merged 5 commits into3.xfrom
fix/missing-character-info-maintenance

Conversation

@herpaderpaldent
Copy link
Contributor

@herpaderpaldent herpaderpaldent commented Apr 20, 2025

Extend maintenance job with GetMissingCharacterInfos to handle missing character information

It could happen that refresh_tokens were present but the character was not. This may cause errors

This addresses partially #665

@herpaderpaldent herpaderpaldent requested a review from Copilot April 20, 2025 17:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses configuration inconsistencies by updating the MariaDB action's host port to match the documented default.

  • Updated host port from 3308 to 3306 in the GitHub workflow configuration
  • Retained commented configuration options for container port and character set for potential future use
Files not reviewed (8)
  • database/migrations/2025_01_02_185356_fix_killmail_items_table.php: Language not supported
  • phpunit.xml: Language not supported
  • src/Jobs/Hydrate/Maintenance/GetMissingCharacterInfos.php: Language not supported
  • src/Jobs/Hydrate/Maintenance/GetMissingTypesFromLocations.php: Language not supported
  • src/Jobs/Seatplus/MaintenanceJob.php: Language not supported
  • src/Jobs/Seatplus/UpdateCorporation.php: Language not supported
  • src/Models/Contacts/ContactLabel.php: Language not supported
  • src/Services/Esi/UpdateRefreshTokenService.php: Language not supported

@what-the-diff
Copy link

what-the-diff bot commented Apr 20, 2025

PR Summary

  • Database Port Update
    The default ship berth port had been changed from 3308 to 3306 to keep a consistent map across the board.

  • New Maintenance Job Addition
    A new job GetMissingCharacterInfos has been enlisted in src/Jobs/Hydrate/Maintenance, responsible for keeping track of the crew information.

  • Code Commentary Updates
    The scripts have been cleaned up, with several unclear and redundant comments removed and new, clearer ones hoisted.

  • Data Access Enhancements
    The ThroughCharacterAssetsFinder and ThroughWalletTransactionsFinder have been refined to fetch nested properties more accurately.

  • Refactoring and Syntax Optimization
    Some unnecessary parentheses have been trimmed from the classes and superfluous whitespace in comments swept clean. Also, UpdateCorporation has new, more simplified syntax for building objects.

  • New Imports
    AllianceInfo, CharacterInfo, and CorporationInfo have been added to our sail logs in ContactLabel.php.

  • Improved Comment Consistency in Test Files
    Comments across different test files had been brushed up to include proper spacing after the comment flag (//).

  • Adding New Import and Test Case in MaintenanceJobTest.php
    A new import statement for GetMissingCharacterInfos along with a new test case to check for any missing crew info from the tokens we get.

  • Comment Formatting
    All instances of //Assert ... were turned into // Assert ... for consistent formatting across all commentaries.

  • Parentheses Removal in Service Call Instantiation
    Parentheses have been removed when creating multiple service classes (no more new ClassName() but new ClassName). This adjustment sailed through various places, like RefreshCharacterAffiliationsServiceTest.php, StationResolverTest.php, and more.

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 23a3a4f and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 96.1% (50% is the threshold).

This pull request will bring the total coverage in the repository to 89.9% (0.0% change).

View more on Code Climate.

@herpaderpaldent herpaderpaldent merged commit e7b2f14 into 3.x Apr 20, 2025
5 of 7 checks passed
@herpaderpaldent herpaderpaldent deleted the fix/missing-character-info-maintenance branch April 20, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants