Handle MemberIDRequired error in joinGroup to support KIP-394 - #1444
Open
sahasan95 wants to merge 1 commit into
Open
Handle MemberIDRequired error in joinGroup to support KIP-394#1444sahasan95 wants to merge 1 commit into
sahasan95 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1432
What
When a Kafka broker returns
MemberIDRequired(error code 79) in responseto a
JoinGrouprequest, the client should retry the request with themember ID assigned by the broker rather than treating it as a fatal error.
This is required by KIP-394
which was introduced in Kafka 2.2.
Why
Without this fix, consumers connecting to Kafka brokers >= 2.2 may fail
to join a consumer group entirely, resulting in an infinite error loop.
Changes
consumergroup.go, after receiving aMemberIDRequirederror fromconn.joinGroup, retry the request with the broker-assigned member IDbefore propagating the error.
Testing
The existing
TestConsumerGroupErrorsmock-based tests pass with this change.A full integration test requires a live Kafka broker with KIP-394 support
(Kafka >= 2.2). Happy to add one if you can point me to the right test
infrastructure or provide a test environment setup.