Skip to content

Handle MemberIDRequired error in joinGroup to support KIP-394 #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sahasan95 wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −1
Open

Handle MemberIDRequired error in joinGroup to support KIP-394 #1444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions consumergroup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,6 +941,15 @@ func (cg *ConsumerGroup) joinGroup(conn coordinator, memberID string) (string, i
if err == nil && response.ErrorCode != 0 {
err = Error(response.ErrorCode)
}
// KIP-394: if the broker requires a member ID before allowing the
// consumer to join the group, retry the join with the assigned member ID.
if err == MemberIDRequired {
request.MemberID = response.MemberID
response, err = conn.joinGroup(request)
if err == nil && response.ErrorCode != 0 {
err = Error(response.ErrorCode)
}
}
if err != nil {
return "", 0, nil, err
}
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/segmentio/kafka-go

go 1.23
go 1.23.0

require (
github.com/klauspost/compress v1.15.9
Expand Down