Skip to content

Fix null projectile type crash in turret shoot #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cursor wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix null projectile type crash in turret shoot #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions Source/SentryTower/Player/SentryTowerTurret.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,20 +55,33 @@ void ASentryTowerTurret::BeginPlay()

void ASentryTowerTurret::Shoot(AActor* TargetActor, const FVector& TargetLocation)
{
float CurrentTime = GetWorld()->GetTimeSeconds();
if (CurrentTime - LastShotTime < AttackCooldown)
if (!ProjectileType)
{
UE_LOG(LogTemp, Warning, TEXT("Turret %s has no projectile type set, skipping shoot"), *GetName());
return;
}

LastShotTime = CurrentTime;
const float CurrentTime = GetWorld()->GetTimeSeconds();
if (CurrentTime - LastShotTime < AttackCooldown)
{
return;
}

FVector SpawnLocation = ProjectileSocket->GetComponentLocation();
FRotator SpawnRotation = TurretWeapon->GetComponentRotation();
const FVector SpawnLocation = ProjectileSocket->GetComponentLocation();
const FRotator SpawnRotation = TurretWeapon->GetComponentRotation();

auto Projectile =
auto Projectile =
Cast<ASentryTowerProjectile>(GetWorld()->SpawnActor(ProjectileType, &SpawnLocation, &SpawnRotation));

if (!Projectile)
{
UE_LOG(LogTemp, Warning, TEXT("Turret %s failed to spawn projectile of type %s"),
*GetName(), *ProjectileType->GetName());
return;
}

LastShotTime = CurrentTime;

Projectile->TargetToFollow = TargetActor;
Projectile->TargetStationary = TargetLocation;

Expand Down