Skip to content

Commit

Permalink
test: Disable DV-P8 tests on Safari (#8147)
Browse files Browse the repository at this point in the history
This is because Apple has introduced a regression in their latest
versions and now they do not work correctly. I hope we can revert this
in a few months.
  • Loading branch information
avelad authored Feb 24, 2025
1 parent 3a47bd1 commit 455fede
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions test/player_dolby_vision_integration.js
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,10 @@ describe('Player Dolby Vision', () => {

describe('P8 with fallback to HEVC', () => {
it('with DASH', async () => {
// This tests is flaky in Safari, so we need omit it for now.
if (shaka.util.Platform.isApple()) {
pending('Disabled on Safari.');
}
if (!await Util.isTypeSupported('video/mp4; codecs="hvc1.2.4.L90.90"',
/* width= */ 640, /* height= */ 360)) {
pending('Codec HEVC is not supported by the platform.');
Expand All @@ -86,6 +90,10 @@ describe('Player Dolby Vision', () => {
});

it('with master playlist (HLS)', async () => {
// This tests is flaky in Safari, so we need omit it for now.
if (shaka.util.Platform.isApple()) {
pending('Disabled on Safari.');
}
if (!await Util.isTypeSupported('video/mp4; codecs="hvc1.2.4.L90.90"',
/* width= */ 640, /* height= */ 360)) {
pending('Codec HEVC is not supported by the platform.');
Expand All @@ -94,6 +102,10 @@ describe('Player Dolby Vision', () => {
});

it('with media playlist (HLS)', async () => {
// This tests is flaky in Safari, so we need omit it for now.
if (shaka.util.Platform.isApple()) {
pending('Disabled on Safari.');
}
if (!await Util.isTypeSupported('video/mp4; codecs="hvc1.2.4.L90.90"',
/* width= */ 640, /* height= */ 360)) {
pending('Codec HEVC is not supported by the platform.');
Expand Down

0 comments on commit 455fede

Please sign in to comment.