Add click url

[amyfain]

I'd like to add click URL to the Events stream and also reduce the bookmark rewind window.

[cmerrick]

Hi @amyfain, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

[cmerrick]

You did it @amyfain!

Thank you for signing the Singer Contribution License Agreement.

[luandy64]

Assuming you run this tap yourself, when you add this URL to the schema and run the tap, do you see this new data being emitted?

If not, I suspect that we need to add 'URL' to the KEY_PROPERTIES list on line 39.

[amyfain]

Yes. I tested this by adding URL to the schema, and it runs without URL being a KEY_PROPERTY.

[amyfain]

@luandy64 do I need to add URL to KEY_PROPERTY?

[dmosorast]

Hi @amyfain, I'm picking this up for Andy. Looking at the code, it looks good the way this is written, no need to add this field to the KEY_PROPERTIES, since it only appears on the Click event type. The key properties are fields that determine a unique record within the stream.

The event stream leaves a bit to be desired the way it is written, since it requests data from many different event types, it seems like the schema should be a superset of all the possible options, differentiated by EventType. Alternatively, it could be broken out into multiple streams to handle click, bounce, etc. events separately.

I think the way to go as written would be to include all of the possible event fields in the schema, and since this is a step in that direction, I'm good to merge it!

No need for the change requested.

[amyfain]

Awesome!! Thanks so much @dmosorast !