Skip to content

Add click url #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmosorast merged 3 commits into from
Nov 27, 2018
Merged

Add click url #19

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1f7f69
Add click URL
amyfain Nov 13, 2018
dfe729e
Reduce bookmark rewind
amyfain Nov 13, 2018
d773bfe
Revert bookmark rewind changes
amyfain Nov 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tap_exacttarget/endpoints/events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ class EventDataAccessObject(DataAccessObject):
'type': ['null', 'string'],
'description': 'The type of tracking event',
},
'URL': {
'type': ['null','string'],
'description': 'URL that was clicked.'
},
Copy link

@luandy64 luandy64 Nov 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you run this tap yourself, when you add this URL to the schema and run the tap, do you see this new data being emitted?

If not, I suspect that we need to add 'URL' to the KEY_PROPERTIES list on line 39.

Copy link
Contributor Author

@amyfain amyfain Nov 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I tested this by adding URL to the schema, and it runs without URL being a KEY_PROPERTY.

Copy link
Contributor Author

@amyfain amyfain Nov 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luandy64 do I need to add URL to KEY_PROPERTY?

'SubscriberKey': SUBSCRIBER_KEY_FIELD,
})

Expand Down