Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to support multiple accounts #187

Merged
merged 22 commits into from
Sep 9, 2024
Merged

Conversation

sirbrillig
Copy link
Owner

@sirbrillig sirbrillig commented Sep 8, 2024

This refactors how the app deals with its fetching system so that it can support fetching multiple accounts at once. Those accounts can be on the same server or on different servers (supporting GitHub Enterprise Server). They can also require a proxy connection.

As a side-effect, this PR (ironically, given the name) decouples the app from the gitnews library itself and replaces it with octokit. Octokit is much better maintained and requires jumping through fewer hoops to make this app's functions work.

Warning

This is a major change to the app. While it will provide a migration from the previous version, it changes quite a lot.

Fixes #184
Fixes #185

To do:

  • Create better UI for account configuration
  • Create new UI for first-time user (to create a new account)
  • Figure out some way to migrate old single-token configuration into account list
  • When accounts change, re-fetch immediately

@sirbrillig sirbrillig marked this pull request as ready for review September 9, 2024 14:26
@sirbrillig sirbrillig merged commit 34f2d48 into trunk Sep 9, 2024
1 check passed
@sirbrillig sirbrillig deleted the add-multiple-accounts branch September 9, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for network proxy Add support for GitHub Enterprise Servers
1 participant