-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to support multiple accounts #187
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirbrillig
force-pushed
the
add-multiple-accounts
branch
from
September 8, 2024 17:01
b4c0d0f
to
0f954b5
Compare
This matches the behavior of gitnews.
This was referenced Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors how the app deals with its fetching system so that it can support fetching multiple accounts at once. Those accounts can be on the same server or on different servers (supporting GitHub Enterprise Server). They can also require a proxy connection.
As a side-effect, this PR (ironically, given the name) decouples the app from the gitnews library itself and replaces it with octokit. Octokit is much better maintained and requires jumping through fewer hoops to make this app's functions work.
Warning
This is a major change to the app. While it will provide a migration from the previous version, it changes quite a lot.
Fixes #184
Fixes #185
To do: