feat(solana)!: enable calling SetConfig without sending the transaction #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0bfcacc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gustavogama-cll
force-pushed
the
enable-set-config-do-not-send-transaction
branch
from
419ea25 to
3bbdf4e
Compare
gustavogama-cll
force-pushed
the
enable-set-config-do-not-send-transaction
branch
from
d96b908 to
9551439
Compare
gustavogama-cll
changed the title
gustavogama-cll
changed the title
| var err error | ||
| for i, instruction := range c.instructions { | ||
| signature, _, err = sendAndConfirmInstructions(ctx, client, auth, | ||
| []solana.Instruction{instruction}, rpc.CommitmentConfirmed) |
There was a problem hiding this comment.
i assumed this wouldn work if we send the whole batch in one go instead of in a loop one at a time?
There was a problem hiding this comment.
not sure I follow; we're still sending+confirming one instruction at a time.
This PR enables clients to call SetConfig() without sending the
instructions to the blockchain. Its purpose is to retrieve the instructions
that _would_ be sent -- to, for instance, use this instructions to
build an mcms proposal. The instructions are returned in the `TransactionResult` object, in the
`RawTransaction` attribute.
In order to "activate" this mode, clients must set leave the authority
private key as `nil` *and* specify the signer account in the
`instructionAuth` parameter. Existing clients (who still want to send
the instructions onchain) are also affected as we had to introduce a new
parameter to the Configurer constructor (`instructionAuth`).
Examples:
```go
// send instructions on-chain
result, err := NewConfigurer(client, auth, solana.PublicKey{}, chainSelector).SetConfig()
assert.True(t, solana.IsSignature(result.Hash))
assert.GreaterOrEqual(t, len(result.RawTransaction.([]solana.Instruction)), 4)
```
```go
// do NOT send instructions on-chain
result, err := NewConfigurer(client, auth, solana.PublicKey{}, chainSelector).SetConfig()
assert.Equal(t, result.Hash, "")
assert.GreaterOrEqual(t, len(result.RawTransaction.([]solana.Instruction)), 4)
```
!BREAKING CHANGE!
…breaking the contract
gustavogama-cll
force-pushed
the
enable-set-config-do-not-send-transaction
branch
from
183448a to
4a6d4e4
Compare
|
ecPablo
approved these changes
Feb 24, 2025
gustavogama-cll
deleted the
enable-set-config-do-not-send-transaction
branch
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 24, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @smartcontractkit/[email protected] ### Minor Changes - [#297](#297) [`2a4a443`](2a4a443) Thanks [@graham-chainlink](https://github.com/graham-chainlink)! - fix: make predecessors parameter optional on NewProposal and NewTimelockProposal - [#310](#310) [`d5d9b16`](d5d9b16) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - feat: enable calling SetConfig without sending the transaction - [#301](#301) [`d8a156c`](d8a156c) Thanks [@akhilchainani](https://github.com/akhilchainani)! - Expose additional functions to help with proposal decoding - [#313](#313) [`4a4a5b5`](4a4a5b5) Thanks [@ecPablo](https://github.com/ecPablo)! - Remove dependency of timelock converter in solana with rpc.Client ### Patch Changes - [#311](#311) [`3808de9`](3808de9) Thanks [@graham-chainlink](https://github.com/graham-chainlink)! - Update to latest chainlink-ccip/chains/solana Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables clients to call SetConfig() without sending the instructions to the blockchain. Its purpose is to retrieve the instructions that would be sent -- to, for instance, use this instructions to build an mcms proposal. The instructions are returned in the
TransactionResultobject, in theRawDataattribute (which used to be calledRawTransactionand was renamed to reflect the fact it can hold other arbitrary types).In order to "activate" this mode, clients must set the optional argument
SkipTransaction. For instance:BREAKING_CHANGE:
RawTransactionrenamed toRawData