Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signature for struct's member #1601

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

wawel37
Copy link
Contributor

@wawel37 wawel37 commented Sep 17, 2024

Fixes #1509. It waits for this to be merged in Cairo.

@piotmag769
Copy link
Contributor

piotmag769 commented Sep 17, 2024

@wawel37 are you sure it resolves #1509 after the PR to compiler is merged? Wouldn't trivia be still there for other signatures? I also believe it would still be there for structs bcs you don't call for the signature of members when generating struct signature

@wawel37
Copy link
Contributor Author

wawel37 commented Sep 19, 2024

@wawel37 are you sure it resolves #1509 after the PR to compiler is merged? Wouldn't trivia be still there for other signatures? I also believe it would still be there for structs bcs you don't call for the signature of members when generating struct signature

You're right. Will create separate Cairo PR to support signatures for structs as a whole.

@wawel37
Copy link
Contributor Author

wawel37 commented Sep 19, 2024

Right now, we're waiting for PR in Cairo removing trivia from signatures. After that, I think, we can change it to review ready 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build signatures without trivia
2 participants