Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make struct members signatures handled in doc group #6387

Merged

Conversation

wawel37
Copy link
Contributor

@wawel37 wawel37 commented Sep 17, 2024

Related to #1601 in Scarb.


This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Arcticae, @Draggu, @mkaput, @piotmag769, and @wawel37)


crates/cairo-lang-doc/src/db.rs line 137 at r1 (raw file):

        }
        SyntaxKind::Member | SyntaxKind::Variant => {
            should_format = false;

comment as to why.

Code quote:

            should_format = false;

Copy link
Collaborator

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @Arcticae, @Draggu, @mkaput, and @wawel37)


crates/cairo-lang-doc/src/db.rs line 138 at r1 (raw file):

        SyntaxKind::Member | SyntaxKind::Variant => {
            should_format = false;
            db.get_children(syntax_node)

Isn't it better to just return here instead of adding this flag?

Copy link
Collaborator

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Arcticae, @Draggu, @mkaput, and @wawel37)


crates/cairo-lang-doc/src/db.rs line 140 at r1 (raw file):

            db.get_children(syntax_node)
                .iter()
                .skip(2)

Just to make sure: you are skipping attributes and visibility identifier?

Copy link
Contributor Author

@wawel37 wawel37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Arcticae, @Draggu, @mkaput, @orizi, and @piotmag769)


crates/cairo-lang-doc/src/db.rs line 137 at r1 (raw file):

Previously, orizi wrote…

comment as to why.

Done.


crates/cairo-lang-doc/src/db.rs line 140 at r1 (raw file):

Previously, piotmag769 (Piotr Magiera) wrote…

Just to make sure: you are skipping attributes and visibility identifier?

Done. Forgot about them, fixed it.

@wawel37 wawel37 requested a review from orizi September 18, 2024 11:06
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @Arcticae, @Draggu, @mkaput, and @piotmag769)

Copy link
Collaborator

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Arcticae, @Draggu, and @mkaput)

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Arcticae, @Draggu, and @mkaput)

@maciektr maciektr added this pull request to the merge queue Sep 19, 2024
Merged via the queue into starkware-libs:main with commit 9c8e97b Sep 19, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants