[chrony] Declare the chrony units in the services tuple - #4437
Open
suraj-cmd wants to merge 1 commit into
Open
Conversation
Both distribution subclasses call add_journal() for their unit but neither declares a services tuple, and neither collects the service status. An sosreport from a host with clock synchronisation problems therefore has chronyc output and the journal, but nothing showing whether the daemon is enabled, running or failing to start. Plugin._collect_services() runs each entry of the tuple through is_service() and calls both add_service_status() and add_journal(), so declaring the unit adds the missing status, keeps the journal, and removes the explicit call. It also gives the plugin an enablement trigger beyond the package name, which matters here because the unit differs between distributions: chronyd on Red Hat, chrony on Debian and Ubuntu. Signed-off-by: Suraj Patil <surajpatil522@gmail.com>
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
Contributor
Author
|
Tested on RHEL 10 (aarch64) with chrony installed by default. Before, on main: After, with this change: The journal was already collected via the explicit add_journal() call; the |
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both distribution subclasses call
add_journal()for their unit but neitherdeclares a
servicestuple, and neither collects the service status. Ansosreport from a host with clock synchronisation problems therefore has
chronycoutput and the journal, but nothing showing whether the daemon isenabled, running or failing to start.
Plugin._collect_services()runs each entry of the tuple throughis_service()and calls bothadd_service_status()andadd_journal(), sodeclaring the unit adds the missing status, keeps the journal, and removes the
explicit call.
It also gives the plugin an enablement trigger beyond the package name, which
matters here because the unit differs between distributions:
chronydon RedHat,
chronyon Debian and Ubuntu.Follows @TurboTurtle's review comment on #4429, and the same change made for
haproxy in #4436. Unlike those, this one also adds data that is not collected
today — neither chrony subclass collects service status at present.
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines