feat: Support multiple destinations for a healthcheck #2704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbylica-splunk
force-pushed
the
support_multiple_destinations_healthcheck
branch
from
8e6388b to
e2272c6
Compare
sbylica-splunk
commented
Feb 17, 2025
sbylica-splunk
commented
Feb 17, 2025
| if re.search(regex, var_key): | ||
| found_destinations.append(var_variable) | ||
| return set(found_destinations) | ||
|
|
There was a problem hiding this comment.
This could be imported from:
But a dot in "conf.d" is causing an import issue. Something to think about later I guess
sbylica-splunk
changed the title
| @@ -14,11 +15,20 @@ def str_to_bool(value): | |||
| 'yes' | |||
| } | |||
|
|
|||
| def get_list_of_destinations(): | |||
There was a problem hiding this comment.
I just have 2 questions:
- Are we planning to backport same logic from
health check apito healthcheck - Are we planning to add same logic on entry point during startup (where we checking that default destination is healthy, probably we also need to check not only default)
P.S. It's just a questions, it doesn't mean that we need to do asap, we will just discuss it
There was a problem hiding this comment.
As for:
- I think that this is too unrelated. In this dockerfile we are checking for syslog-ng before SC4S is initialised. We "could" also check for HEC health but I'm not sure if this change makes sense.
- Similar thing really. In this line we are checking mostly for HEC token and default endpoint. I could see a separate check for other HEC endpoints - it could even use the method I just implemented, but it should probably just show warnings.
There was a problem hiding this comment.
@mstopa-splunk @rjha-splunk - we can talk about this on our sc4s meeting
…estinations_healthcheck
ikheifets-splunk
approved these changes
Mar 11, 2025
There was a problem hiding this comment.
@rjha-splunk @mstopa-splunk can you please take a look on this comment https://github.com/splunk/splunk-connect-for-syslog/pull/2704/files#r1963384996
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.