Simplify state of selected account #2010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will test this more tomorrow together with a new |
ekzyis
force-pushed
the
account-refactor-2
branch
from
a2b8bbe to
66608a4
Compare
ekzyis
force-pushed
the
account-refactor-2
branch
from
d2c59c4 to
21408d2
Compare
This was referenced Mar 24, 2025
ekzyis
force-pushed
the
account-refactor-2
branch
from
21408d2 to
4d666e9
Compare
|
This PR is useless, all changes are overriden by #2019. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on #2009mergedSince we always call
router.reload()after selecting an account, most of my code regarding which account is selected was not necessary.The only difference is that we now no longer show that the selection changed even before the page reloaded but I think removing this code is worth it.
Additional Context
Cleaning up the foundation to add a
useCookiefunction to fix #2007 (comment).Checklist
Are your changes backwards compatible? Please answer below:
yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
8. I tested switching to anon and to a different user.For frontend changes: Tested on mobile, light and dark mode? Please answer below:
n/a
Did you introduce any new environment variables? If so, call them out explicitly here:
no