Skip to content

Conversation

@moodmosaic
Copy link
Contributor

Ideally, these tests would live in boot-contracts-stateful-prop-tests, but sip-031.test.ts (example-based tests) was placed in contrib/core-contract-tests, so this follows that pattern to avoid unnecessary git noise.

Details on how to run the two test suites — outside-in stateful testing with Clarinet and fast-check, and inside-out with Rendezvous — will follow shortly.

@moodmosaic moodmosaic requested review from a team July 22, 2025 17:26
@moodmosaic
Copy link
Contributor Author

To run the outside-in stateful testing with Clarinet and fast-check:

cd contrib/core-contract-tests
npx vitest tests/sip-031/sip-031.stateful.prop.test.ts
image

@BowTiedRadone
Copy link
Contributor

BowTiedRadone commented Jul 22, 2025

Quick guide on how to run the Rendezvous Clarity property tests and invariants:

cd contrib/core-contract-tests
npm i
# To run property tests:
npx rv . sip-031 test
# To run invariant tests:
npx rv . sip-031 invariant

To increase the number of runs of a testing routine (100 by default), you can use:

npx rv . sip-031 test --runs=1000

On failure (shouldn't be the case at this point), a seed is reported at the end of the run. You can use that seed to reproduce the exact same sequence of events:

npx rv . sip-031 test --seed=<REPRO_SEED>

Sample output:

Screenshot 2025-07-22 at 8 33 34 PM

@hstove
Copy link
Contributor

hstove commented Jul 24, 2025

@BowTiedRadone I pushed a 1-line change for the pox-4 tests - the privateKeyMapping object needed the new account

@moodmosaic moodmosaic marked this pull request as draft July 24, 2025 15:53
@BowTiedRadone
Copy link
Contributor

@hstove thanks! I'm looking into the remaining failing tests.

@moodmosaic moodmosaic marked this pull request as ready for review July 24, 2025 16:48
@moodmosaic moodmosaic force-pushed the sip31-prop-tests branch 3 times, most recently from f223d26 to 2e3e92f Compare July 25, 2025 13:51
@wileyj wileyj added this to the 3.2.0.0.1 milestone Jul 25, 2025
@wileyj wileyj moved this to Status: In Review in Stacks Core Eng Jul 25, 2025
Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this from Status: In Review to Status: 💻 In Progress in Stacks Core Eng Jul 28, 2025
@moodmosaic moodmosaic enabled auto-merge July 29, 2025 07:47
@moodmosaic moodmosaic added this pull request to the merge queue Jul 29, 2025
Merged via the queue into stacks-network:develop with commit 63f180e Jul 29, 2025
1 of 2 checks passed
@moodmosaic moodmosaic deleted the sip31-prop-tests branch July 29, 2025 08:36
@github-project-automation github-project-automation bot moved this from Status: 💻 In Progress to Status: ✅ Done in Stacks Core Eng Jul 29, 2025
@codecov
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.95%. Comparing base (4850f72) to head (225d25b).
⚠️ Report is 14 commits behind head on develop.

❌ Your project status has failed because the head coverage (55.95%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (4850f72) and HEAD (225d25b). Click for more details.

HEAD has 39 uploads less than BASE
Flag BASE (4850f72) HEAD (225d25b)
122 83
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6321       +/-   ##
============================================
- Coverage    80.79%   55.95%   -24.85%     
============================================
  Files          541      541               
  Lines       347771   347771               
============================================
- Hits        280993   194598    -86395     
- Misses       66778   153173    +86395     

see 421 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4850f72...225d25b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Aug 6, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot added the locked label Aug 6, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

Status: Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

5 participants