-
Notifications
You must be signed in to change notification settings - Fork 724
fix: clippy issue due to rust 1.89.0 update #6356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: clippy issue due to rust 1.89.0 update #6356
Conversation
Jiloc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Could you also remove this line?
| export RUSTFLAGS="${RUSTFLAGS:-} -A mismatched-lifetime-syntaxes" |
It was added because that project uses nightly, and CI was failing because of it. Now that we addressed it, I believe we can remove it
Jiloc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, no need to do this change in this PR. We can have it in a separete PR (I also have other clippy fixes that came out with 1.88 for that crate). The sooner we merge this, the sooner we unlock the merge queue.
0f12a72
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (74.60%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #6356 +/- ##
============================================
+ Coverage 55.06% 74.60% +19.54%
============================================
Files 552 552
Lines 351807 351807
============================================
+ Hits 193727 262476 +68749
+ Misses 158080 89331 -68749
... and 379 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
This PR fixes the following Clippy lints, which are now treated as hard errors due to the
-D warningsflag in Rust1.89.0:clippy::mismatched-lifetime-syntaxesclippy::non-canonical-partial-ord-implApplicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yamlandrpc-endpoints.mdfor v2 endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepobitcoin-tests.yml