Skip to content

Conversation

@fdefelici
Copy link
Contributor

Description

This PR fixes the following Clippy lints, which are now treated as hard errors due to the -D warnings flag in Rust 1.89.0:

  • clippy::mismatched-lifetime-syntaxes
  • clippy::non-canonical-partial-ord-impl

Applicable issues

  • fixes #

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@fdefelici fdefelici requested review from a team August 7, 2025 15:23
@fdefelici fdefelici self-assigned this Aug 7, 2025
@fdefelici fdefelici added this to the 3.2.0.0.1 milestone Aug 7, 2025
Copy link
Contributor

@Jiloc Jiloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Could you also remove this line?

export RUSTFLAGS="${RUSTFLAGS:-} -A mismatched-lifetime-syntaxes"

It was added because that project uses nightly, and CI was failing because of it. Now that we addressed it, I believe we can remove it

Copy link
Contributor

@Jiloc Jiloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, no need to do this change in this PR. We can have it in a separete PR (I also have other clippy fixes that came out with 1.88 for that crate). The sooner we merge this, the sooner we unlock the merge queue.

@fdefelici fdefelici enabled auto-merge August 7, 2025 16:17
@fdefelici fdefelici added this pull request to the merge queue Aug 7, 2025
Merged via the queue into stacks-network:develop with commit 0f12a72 Aug 7, 2025
1 of 2 checks passed
@fdefelici fdefelici deleted the fix/clippy-rust-1-89 branch August 7, 2025 17:07
@codecov
Copy link

codecov bot commented Aug 7, 2025

Codecov Report

❌ Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.60%. Comparing base (762e44b) to head (923f715).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
clarity/src/vm/database/clarity_store.rs 50.00% 1 Missing ⚠️
stacks-common/src/util/vrf.rs 0.00% 1 Missing ⚠️

❌ Your project status has failed because the head coverage (74.60%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6356       +/-   ##
============================================
+ Coverage    55.06%   74.60%   +19.54%     
============================================
  Files          552      552               
  Lines       351807   351807               
============================================
+ Hits        193727   262476    +68749     
+ Misses      158080    89331    -68749     
Files with missing lines Coverage Δ
clarity/src/vm/analysis/type_checker/contexts.rs 95.06% <100.00%> (ø)
clarity/src/vm/contexts.rs 89.01% <100.00%> (+6.34%) ⬆️
clarity/src/vm/database/sqlite.rs 83.39% <100.00%> (ø)
clarity/src/vm/tests/mod.rs 60.93% <100.00%> (+7.81%) ⬆️
stacks-common/src/bitvec.rs 88.02% <100.00%> (+41.90%) ⬆️
...common/src/deps_common/bitcoin/blockdata/script.rs 77.29% <100.00%> (+29.45%) ⬆️
stacks-common/src/types/sqlite.rs 100.00% <100.00%> (ø)
stacks-common/src/util/macros.rs 86.59% <100.00%> (+9.96%) ⬆️
stacks-node/src/event_dispatcher.rs 82.54% <100.00%> (+15.89%) ⬆️
...tackslib/src/chainstate/nakamoto/staging_blocks.rs 90.38% <100.00%> (ø)
... and 4 more

... and 379 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 762e44b...923f715. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

Status: Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants