Remove Connection response header in Async (Fibers) mode #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Falcon Ruby server (currently the option for Fiber-based concurrency) ignores "hop headers" such as Connection, and displays a warning in HTTP mode (it just removes them in HTTPS) https://github.com/socketry/falcon/blob/8292c26f6972b88149bc1dc5f9abb1f9c66ca039/lib/falcon/middleware/proxy.rb#L35 When using the AsyncExecutor (ie running under Falcon), remove the Connection header from the Response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Falcon Ruby server (currently the option for Fiber-based concurrency) ignores "hop headers" such as Connection, and displays a warning in HTTP mode (it just removes them in HTTPS)
https://github.com/socketry/falcon/blob/8292c26f6972b88149bc1dc5f9abb1f9c66ca039/lib/falcon/middleware/proxy.rb#L35
When using the AsyncExecutor (ie running under Falcon), remove the Connection header from the Response.