Skip to content

Remove Connection response header in Async (Fibers) mode #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ismasan merged 1 commit into from
Nov 22, 2025
Merged

Remove Connection response header in Async (Fibers) mode #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/datastar/async_executor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ def initialize

def new_queue = Async::Queue.new

def prepare(response); end
def prepare(response)
response.delete_header 'Connection'
end

def spawn(&block)
Async(&block)
Expand Down
10 changes: 10 additions & 0 deletions spec/async_executor_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# frozen_string_literal: true

RSpec.describe Datastar::AsyncExecutor do
it 'removes Connection header from response' do
executor = described_class.new
response = Rack::Response.new(nil, 200, { 'Connection' => 'keep-alive'})
executor.prepare(response)
expect(response.headers.key?('Connection')).to be(false)
end
end